Skip to content

🚑 Fixed: "Could not find package annotations" in composer r… #14198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2020
Merged

🚑 Fixed: "Could not find package annotations" in composer r… #14198

merged 1 commit into from
Sep 8, 2020

Conversation

albuquerque53
Copy link

@albuquerque53 albuquerque53 commented Sep 8, 2020

Apparently, the "annotations" package doesn't exists. I saw in packagist page that the routing component requires a 'doctrine/annotations: ~1.2'.
Packagist symfony/routing url: https://packagist.org/packages/symfony/routing

@javiereguiluz
Copy link
Member

There was a package called annotations-pack (see https://packagist.org/packages/symfony/annotations-pack) which allowed to run composer require annotations (when using Symfony Flex). But it's been removed, so thanks for fixing this!

@javiereguiluz javiereguiluz changed the title 🚑 Fixed: "Could not find package annotations" in composer r… 🚑 Fixed: "Could not find package annotations" in composer r… Sep 8, 2020
@javiereguiluz javiereguiluz added this to the 4.4 milestone Sep 8, 2020
Apparently, the "annotations" package doesn't exists. I saw in packagist page that the routing component requires a 'doctrine/annotations: ~1.2'.
Packagist symfony/routing url: https://packagist.org/packages/symfony/routing
@javiereguiluz
Copy link
Member

It's merged now! Thanks!

@albuquerque53
Copy link
Author

It's merged now! Thanks!

You're welcome!

@Nyholm
Copy link
Member

Nyholm commented Oct 11, 2020

I reverted this PR in #14387

javiereguiluz added a commit that referenced this pull request Oct 11, 2020
…doctrine/annotations (Nyholm)

This PR was submitted for the 5.x branch but it was merged into the 4.4 branch instead.

Discussion
----------

Make sure we install FrameworkExtra bundle and not just doctrine/annotations

This PR will fix #14203 and revert #14198

@javiereguiluz wrote:

> There was a package called annotations-pack (see https://packagist.org/packages/symfony/annotations-pack) which allowed to run composer require annotations (when using Symfony Flex)

This is true. The pack was removed. Currently there is a flex alias to install SensioFrameworkExtraBundle when one run `composer require annotations`. That will make sure to install SensioFrameworkExtraBundle and doctrine/annotations.

One will always need SensioFrameworkExtraBundle to be able to use route config with annotations, only doctrine/annotations is not good enough.

------

People that is not using Flex will see the `Could not find package annotations` as @albuquerque53 saw.

Commits
-------

fa569bd Make sure we install FrameworkExtra bundle and not just doctrine/annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants